Enable compactor to use 'TokensFilePath' on ring lifecycler #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblando
changed the title
danielblando
force-pushed
the
compactor-tokens
branch
from
0ba0c9b to
7f9bb0b
Compare
yeya24
approved these changes
Jun 28, 2023
danielblando
force-pushed
the
compactor-tokens
branch
from
7186614 to
d8125c2
Compare
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
danielblando
force-pushed
the
compactor-tokens
branch
from
d8125c2 to
08b9f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add configuration for compactor to save token on file
Which issue(s) this PR fixes:
In some scenarios (slow compactor), we can run into situations that 2 compactor are compacting the same customer. Compactor-A start cleaning from tenant-123, then a service restart occur and compactor-b with the new tokens is the owner of tenant-123, compactor-b also start cleaning of tenant -123.
This change avoids multiple resharding when compactors are restarted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]