Avoid concurrency between heartbeat and autoJoin #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
alanprot
approved these changes
Jun 29, 2023
yeya24
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a min value to jitter delay.
Improve flake test
Which issue(s) this PR fixes:
On #5404 while adding jitter to heartbeat, we increased the chance of a concurrency issue between autoJoin and heartbeat. We do have in some cases where autoJoin fails and need to retry situations where a instance can go to ACTIVE with no tokens.
On #5428, we try to mitigate it by also synicng the tokens, but this can create performance overhead when we have conflict tokens between instances.
We are here adding a min value for the jitter to avoid concurrency and braking tests.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]