Implementing multi level index cache #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
multi-level-indexcache
branch
from
c74eda1 to
b8e4daf
Compare
2 tasks
yeya24
reviewed
Jul 12, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
multi-level-indexcache
branch
2 times, most recently
from
771c27f to
bb01d9e
Compare
harry671003
reviewed
Jul 12, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
multi-level-indexcache
branch
from
bb01d9e to
e0fba4f
Compare
alanprot
force-pushed
the
multi-level-indexcache
branch
from
12acde1 to
35ed300
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
multi-level-indexcache
branch
from
35ed300 to
d37bdf3
Compare
qinxx108
pushed a commit
to qinxx108/cortex
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/cortex
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alvinlin123
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Implementing Bucket index sync status file (#5446) * Implementing Bucket index sync status Signed-off-by: Alan Protasio <alanprot@gmail.com> * fixing bug when returning from cache Signed-off-by: Alan Protasio <alanprot@gmail.com> * Addressing some comments Signed-off-by: Alan Protasio <alanprot@gmail.com> * Changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com> * Implementing multi level index cache (#5451) Signed-off-by: Yijie Qin <qinyijie@amazon.com> * remove the user from am state replication key Signed-off-by: Yijie Qin <qinyijie@amazon.com> * expose the key label Signed-off-by: Yijie Qin <qinyijie@amazon.com> * add Changelog Signed-off-by: Yijie Qin <qinyijie@amazon.com> * fix comments Signed-off-by: Yijie Qin <qinyijie@amazon.com> * change to use type Signed-off-by: Yijie Qin <qinyijie@amazon.com> * address comment Signed-off-by: Yijie Qin <qinyijie@amazon.com> * fix comment Signed-off-by: Yijie Qin <qinyijie@amazon.com> * use type instead of key Signed-off-by: Yijie Qin <qinyijie@amazon.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com> Co-authored-by: Alan Protasio <approtas@amazon.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implementing multi-level caching for the index cache.
With the PR we will be able to configure multiples caching layers like for example "inMemory" as L1 cache and "memcache" as l2 cache.
The configuration will now accept a
Comma separated ordered list of index cache backend typeand cortex will use the cache in order (l1,l2,ln).Currently we don't "backfill" the data from a Ln+1 to a Ln cache but this can be implemented in the future.
PS: This change should be a NoOp if only 1 cache is configured.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]