add alert name in error log #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
force-pushed
the
add-alert-name-in-error
branch
from
69ca07b to
f9b17ff
Compare
qinxx108
force-pushed
the
add-alert-name-in-error
branch
from
f9b17ff to
72a731a
Compare
friedrichg
approved these changes
Jul 14, 2023
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alvinlin123
reviewed
Jul 14, 2023
CHANGELOG.md
Outdated
| @@ -52,6 +52,7 @@ | |||
| * [BUGFIX] Store Gateway: Fix bug in store gateway ring comparison logic. #5426 | |||
| * [BUGFIX] Ring: Fix bug in consistency of Get func in a scaling zone-aware ring. #5429 | |||
| * [BUGFIX] Query Frontend: Fix bug of failing to cancel downstream request context in query frontend v2 mode (query scheduler enabled). #5447 | |||
| * [ENHANCEMENT] Alertmanager: Add the alert name in error log when it get throttled. #5456 | |||
There was a problem hiding this comment.
Let's have this enhancement close to other enhancements.
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alvinlin123
approved these changes
Jul 14, 2023
yeya24
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add the alert name in the error log
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]