-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingester flag to customize message in limiter error messages #5460
Add ingester flag to customize message in limiter error messages #5460
Conversation
Signed-off-by: Nikhil Kumar <nikhil.kumar.92219@gmail.com>
@friedrichg Have a look I was thinking of adding tests for checking contact details at- cortex/pkg/ingester/limiter_test.go Lines 504 to 508 in 21eb075
Or should I create a completely new test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
You don't need to add any additional tests, just keep the current tests working.
Signed-off-by: Nikhil Kumar <nikhil.kumar.92219@gmail.com>
Signed-off-by: Nikhil Kumar <nikhil.kumar.92219@gmail.com>
Signed-off-by: Nikhil Kumar <nikhil.kumar.92219@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @kumanik , the only thing missing is a FEATURE in the CHANGELOG.
Signed-off-by: Nikhil Kumar <nikhil.kumar.92219@gmail.com>
4c3061f
to
e17e98b
Compare
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
It is done I suppose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No, thank you. Really glad I could contribute. If there is anything to work on I would like to help. |
What this PR does:
Adds an admin contact address flag to the ingester and uses it while printing error messages when hitting limits.
Which issue(s) this PR fixes:
Fixes #5452
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]