Add cortex_ingester_tsdb_data_replay_duration_seconds metric #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damnever
force-pushed
the
feat/tsdb-datareplay-metrics
branch
from
7b1c15f to
3cde681
Compare
|
Hi @damnever, sorry for the late review. I think this change looks good and we can add the metric. |
damnever
force-pushed
the
feat/tsdb-datareplay-metrics
branch
from
3cde681 to
40baccf
Compare
|
@damnever Can you please update the unit test as well? https://github.com/cortexproject/cortex/blob/master/pkg/ingester/metrics_test.go#L481 |
damnever
force-pushed
the
feat/tsdb-datareplay-metrics
branch
from
671a481 to
812dad0
Compare
|
@yeya24 unit test updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #5471
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]