allow compactor unregisteronshutdown to be configurable #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Xu <wenxuamz@amazon.com>
wenxu1024
force-pushed
the
compactor-unregister-on-shutdown
branch
from
0ab7cea to
eac2822
Compare
Signed-off-by: Wen Xu <wenxuamz@amazon.com>
wenxu1024
added a commit
to wenxu1024/cortex
that referenced
this pull request
Aug 9, 2023
…t#5503) * allow compactor unregisteronshutdown to be configurable Signed-off-by: Wen Xu <wenxuamz@amazon.com> * fix lint, add changelog Signed-off-by: Wen Xu <wenxuamz@amazon.com> --------- Signed-off-by: Wen Xu <wenxuamz@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Allow the compactor ring unregisteronshutdown to be configurable. So during compactor statefulset rollout restart, the ring topology can stay the same, without causing resharding and re download of blocks.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]