Creating new metric around chunks bytespool #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <alanprot@gmail.com>
yeya24
reviewed
Sep 7, 2023
yeya24
reviewed
Sep 7, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
chunks-metric
branch
3 times, most recently
from
a1ee8de to
46a10c4
Compare
yeya24
approved these changes
Sep 8, 2023
alvinlin123
reviewed
Sep 8, 2023
| }), | ||
| poolByteStats: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "cortex_bucket_store_chunk_pool_operation_bytes_total", | ||
| Help: "Total bytes number of bytes pooled by operation.", |
There was a problem hiding this comment.
My suggestion for this would be "Bytes checkout or returned to the chunk pool"
There was a problem hiding this comment.
humm.. idk.. i think s too verbose
alvinlin123
reviewed
Sep 8, 2023
alvinlin123
approved these changes
Sep 8, 2023
alanprot
force-pushed
the
chunks-metric
branch
2 times, most recently
from
de6bbf0 to
b045e8a
Compare
alanprot
force-pushed
the
chunks-metric
branch
from
b045e8a to
1072a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Create new
cortex_bucket_store_chunk_pool_bytes_totalto add metrics around the byte slices returned to the pool.This metric has a overlap with the existing ones - which should be deprecated if this PR is accepted.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]