Separate query limits for store gateway #5579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
harry671003
reviewed
Mar 18, 2024
| # The maximum number of series to fetch per gRPC request in Store Gateway, | ||
| # including Series/LabelNames/LabelValues requests. 0 to disable. | ||
| # CLI flag: -store-gateway.max-series-per-request | ||
| [max_series_per_request: <int> | default = 0] |
There was a problem hiding this comment.
These limits are not deterministic? Doesn't it depend on how the blocks where sharded on store-gateways? Could we implement this per block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pr separates the query limits for SG, mainly series and chunks limit. Previously we use the same limits from querier for store gateways.
That works but the issue is that querier usually aggregates data from multiple store gateways so the limit is usually high. Having such a high limit on a single request to store gateway might not protect anything.
As first step, I think we can start exposing limits specifc for SGs. LF some feedbacks as this is a breaking change.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]