Add metric to measure rule group load time #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Oct 18, 2023
rajagopalanand
force-pushed
the
rulegroup-loadtime-metric
branch
3 times, most recently
from
c1d3bbd to
3ff5102
Compare
yeya24
approved these changes
Oct 20, 2023
yeya24
approved these changes
Oct 20, 2023
Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
rajagopalanand
force-pushed
the
rulegroup-loadtime-metric
branch
from
3ff5102 to
dde22b9
Compare
yeya24
reviewed
Oct 20, 2023
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## master / unreleased | |||
| * [CHANGE] Ruler: Add `cortex_ruler_rule_group_load_duration_seconds` and `cortex_ruler_rule_group_sync_duration_seconds` metrics. #5609 | |||
There was a problem hiding this comment.
Well @rajagopalanand, I merged it too early. It is an enhancement, not a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds 2 metrics to track the following
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]