Disable upload compacted blocks and overlapping compaction in ingester #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichg
approved these changes
Jan 25, 2024
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
disable-overlap-compaction
branch
from
026638d to
e1acac9
Compare
CharlieTLe
added a commit
to CharlieTLe/cortex
that referenced
this pull request
May 18, 2024
… parameterize uploading compacted blocks In v1.15.2, ingesters configured with OOO samples ingestion enabled could hit this bug (cortexproject#5402) where ingesters would not upload compacted blocks (thanos-io/thanos#6462). In v1.16.1, ingesters are configured to always upload compacted blocks (cortexproject#5625). In v1.17, ingesters stopped uploading compacted blocks (cortexproject#5735). This can cause problems for users upgrading from v1.15.2 with OOO ingestion enabled to v1.17 because both versions are hard coded to disable uploading compacted blocks from the ingesters. The workaround was to downgrade from v1.17 to v1.16 to allow those compacted blocks to be uploaded (and eventually deleted). The new flag is set to true by default which reverts the behavior of the ingester uploading compacted blocks back to v1.16. Signed-off-by: Charlie Le <charlie_le@apple.com>
3 tasks
yeya24
pushed a commit
that referenced
this pull request
May 19, 2024
… parameterize uploading compacted blocks (#5959) In v1.15.2, ingesters configured with OOO samples ingestion enabled could hit this bug (#5402) where ingesters would not upload compacted blocks (thanos-io/thanos#6462). In v1.16.1, ingesters are configured to always upload compacted blocks (#5625). In v1.17, ingesters stopped uploading compacted blocks (#5735). This can cause problems for users upgrading from v1.15.2 with OOO ingestion enabled to v1.17 because both versions are hard coded to disable uploading compacted blocks from the ingesters. The workaround was to downgrade from v1.17 to v1.16 to allow those compacted blocks to be uploaded (and eventually deleted). The new flag is set to true by default which reverts the behavior of the ingester uploading compacted blocks back to v1.16. Signed-off-by: Charlie Le <charlie_le@apple.com>
yeya24
pushed a commit
that referenced
this pull request
May 20, 2024
… parameterize uploading compacted blocks (#5959) In v1.15.2, ingesters configured with OOO samples ingestion enabled could hit this bug (#5402) where ingesters would not upload compacted blocks (thanos-io/thanos#6462). In v1.16.1, ingesters are configured to always upload compacted blocks (#5625). In v1.17, ingesters stopped uploading compacted blocks (#5735). This can cause problems for users upgrading from v1.15.2 with OOO ingestion enabled to v1.17 because both versions are hard coded to disable uploading compacted blocks from the ingesters. The workaround was to downgrade from v1.17 to v1.16 to allow those compacted blocks to be uploaded (and eventually deleted). The new flag is set to true by default which reverts the behavior of the ingester uploading compacted blocks back to v1.16. Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change basically reverts #5625 and enables a new flag introduced in Prometheus prometheus/prometheus#13393 to always disable overlapping compaction in ingester.
This new flag makes sure that all overlapping compaction happens at compactor side and ingester doesn't need to waste resources to do vertical compaction.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]