Collect store gateway postings touched count and bytes in querier stats #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
store-gateway-postings-touched
branch
from
88b280f to
8fe057c
Compare
alanprot
approved these changes
Apr 26, 2024
Kramer0x0
pushed a commit
to Kramer0x0/cortex
that referenced
this pull request
Apr 26, 2024
…ts (cortexproject#5892) * update stats Signed-off-by: Ben Ye <benye@amazon.com> * update stats Signed-off-by: Ben Ye <benye@amazon.com> * collect store gateway postings touched count and bytes in querier stats Signed-off-by: Ben Ye <benye@amazon.com> * changelog Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds two new fields to query stats.
store_gateway_touched_postings_countandstore_gateway_touched_posting_bytesare added to collect number of postings touched and corresponding sizes of the postings in Store Gateway for the corresponding query.These 2 stats can be used to help troubleshoot query performance problem to Store Gateway.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]