Changing the per labelset config to be more generic #5993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
MaxSeriesPerLabelset was introduced on #5950 but the configuration format would not allow us in the future to configure more limits as "samples ingested per labelset"
This PR is just changing the configuration to be a bit more generic where we can extend to other limits in the future:
Config Before:
Config Now:
We also changed the usage metric from
cortex_ingester_active_series_per_labelset
tocortex_ingester_usage_per_labelset
and created a new metric with the configured limit:cortex_ingester_limits_per_labelset
as follow:Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]