Enable native histogram for Cortex req duration metric #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tric Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
approved these changes
Jul 2, 2024
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
deleted the
enable-native-histogram-cortex_request_duration_seconds-metric
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR changes Cortex server to always enable native histogram instrumentation for
cortex_request_duration_secondsmetric.This is a change for Cortex users if their monitoring Prometheus enables
native-histogramfeature.cortex_request_duration_seconds_bucket,cortex_request_duration_seconds_sumandcortex_request_duration_seconds_countmetric will be converted into native histogramcortex_request_duration_seconds.If
native-histogramfeature is not enabled then there is no user facing changes.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]