Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique execution ID for each compaction cycle in log for easy debugging #6097

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

alexqyle
Copy link
Contributor

@alexqyle alexqyle commented Jul 18, 2024

What this PR does:

Created WithExecutionID wrapper for log and use it for each compaction cycle. With this, it is easier to debug compactor issue through log.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…ugging

Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@danielblando danielblando merged commit caa762e into cortexproject:master Jul 18, 2024
16 checks passed
@alexqyle alexqyle deleted the compactor-execution-id branch July 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants