Implement metadata API limit in Ingester #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
implement_metadata_limit
branch
from
2e836c6 to
8671cac
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
|
Nice! We will follow up with a SG PR? @harry671003 |
Yes. I'm making the changes in Thanos stores. After Thanos is updated, I'll implement this in store-gateways. |
Signed-off-by: Alan Protasio <approtas@amazon.com>
yeya24
reviewed
Aug 9, 2024
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
yeya24
reviewed
Aug 13, 2024
| @@ -41,6 +41,7 @@ | |||
| * [ENHANCEMENT] Compactor: Split cleaner cycle for active and deleted tenants. #6112 | |||
| * [ENHANCEMENT] Compactor: Introduce cleaner visit marker. #6113 | |||
| * [ENHANCEMENT] Query Frontend: Add cortex_query_samples_total metric. #6142 | |||
| * [ENHANCEMENT] Ingester: Implement metadata API limit. #6128 | |||
There was a problem hiding this comment.
I think we can call it a feature maybe. But fine as an enhancement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR passes the
limitparam from series, label names and label values API into ingesters. Ingesters will only return a maximum of limit results if the param is set.Note: I tested that adding the limit field in ingester API is both backwards and forwards compatible.
Which issue(s) this PR fixes:
Fixes #6127
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]