Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cortex_ingester_tsdb_mmap_chunks_total metric #6134

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Aug 2, 2024

What this PR does:

Fix cortex_ingester_tsdb_mmap_chunks_total metric. This metric is prometheus_tsdb_mmap_chunks_total is a counter, not a gauge.

https://github.com/prometheus/prometheus/blob/5681ec50e1fc1e591c4dcc63eb343478ea2082ee/tsdb/head.go#L498-L501
Screenshot 2024-08-02 at 3 41 16 PM

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot marked this pull request as ready for review August 2, 2024 22:41
@alanprot alanprot requested a review from yeya24 August 2, 2024 22:43
Signed-off-by: alanprot <alanprot@gmail.com>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 2, 2024
@yeya24 yeya24 enabled auto-merge (squash) August 2, 2024 23:01
@yeya24 yeya24 merged commit 2bf1b61 into cortexproject:master Aug 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants