Support peakSamples in query frontend response #6188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Support-peakSamples-in-query-frontend-response
branch
from
09be4fa to
8620d9d
Compare
yeya24
reviewed
Sep 4, 2024
SungJin1212
force-pushed
the
Support-peakSamples-in-query-frontend-response
branch
from
8620d9d to
d1e7760
Compare
|
Umm sorry @SungJin1212, #6180 introduced quite a lot of conflicts to this PR. Can you please rebase and address conflicts so that we can merge? Thanks again for the great work! |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Support-peakSamples-in-query-frontend-response
branch
from
d1e7760 to
1134ecf
Compare
|
@yeya24 |
yeya24
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support peakSamples in query frontend response. The peakSamples are the maximum samples kept in memory during the query execution.
Which issue(s) this PR fixes:
Fixes #6181
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]