Add in-memory chunk cache #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-inmemory-chunk-cache
branch
from
67bedbf to
975b5c3
Compare
SungJin1212
commented
Sep 30, 2024
Comment on lines
-5
to
+6
| * [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527 | ||
| * [CHANGE] Enable Compactor and Alertmanager in target all. #6204 | ||
| * [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527 |
There was a problem hiding this comment.
I just changed the order.
SungJin1212
force-pushed
the
Add-inmemory-chunk-cache
branch
3 times, most recently
from
d1fa7fa to
ea70f2c
Compare
|
@yeya24 |
SungJin1212
force-pushed
the
Add-inmemory-chunk-cache
branch
from
ea70f2c to
dc50383
Compare
|
@SungJin1212 I prefer to stick to current behavior to not enable chunks caching as default. |
SungJin1212
force-pushed
the
Add-inmemory-chunk-cache
branch
from
dc50383 to
a094b6e
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-inmemory-chunk-cache
branch
from
a094b6e to
c62c7b1
Compare
|
@yeya24 |
yeya24
approved these changes
Oct 1, 2024
friedrichg
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an in-memory chunk cache to Store Gateway.
Which issue(s) this PR fixes:
Fixes #6239
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]