-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-level chunk cache #6249
Add multi-level chunk cache #6249
Conversation
f89b7d2
to
f92795d
Compare
Can we fix tests? |
8663f64
to
0446dfe
Compare
@yeya24 |
Hi @SungJin1212, I tested your PR locally but it got a panic when registering metrics. My store gateway set up has metadata cache to use memcached and chunks cache to use multi level cache: inmemory as first level and memcached as second level. I think the panic was caused by the new
|
@yeya24 |
0446dfe
to
fa78fa2
Compare
@yeya24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The feature looks good. I have tried it in our test cluster and it saved quite a lot of Store Gateway and Chunks Cache bandwidth, especially when you have rules with a long lookback window.
fa78fa2
to
7add2ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Waiting for another approval before merging this.
We have a conflict seems aftering merging the previous PR |
LGTM! |
7add2ef
to
5cfcfd7
Compare
@SungJin1212 Need to fix lint |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
5cfcfd7
to
7947e88
Compare
Support multi-level chunk cache like a multi-level cache for the index and add metrics for tracking multi-level cache behavior.
cortex_store_multilevel_chunks_cache_fetch_duration_seconds
, tracks latency to fetch itemcortex_store_multilevel_chunks_cache_backfill_duration_seconds
, tracks latency to backfill itemcortex_store_multilevel_chunks_cache_backfill_dropped_items_total
, tracks # of dropped items due to buffer fullness when backfillingcortex_store_multilevel_chunks_cache_store_dropped_items_total
, tracks # of dropped items due to buffer fullness when storingAdd a multi level chunk cache
Which issue(s) this PR fixes:
Fixes #6240
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]