-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put ingester disable chunk trimming a feature flag #6300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
disable-chunk-trimming
branch
from
November 1, 2024 03:41
bce5678
to
5bbe234
Compare
yeya24
commented
Nov 1, 2024
for { | ||
expr = ps.WalkRangeQuery() | ||
query = expr.Pretty(0) | ||
if !strings.Contains(query, "timestamp") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We on purposely ignore timestamp
to reduce flakiness as it is a know imcompatible behavior
alanprot
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye benye@amazon.com<!-- Thanks for sending a pull request! Before submitting:
-->
What this PR does:
This changes #6270 to mark the behavior optional under a feature flag.
We noticed that query result got changed if disabling chunk trimming for the following test case, captured by fuzz test.
https://github.com/cortexproject/cortex/actions/runs/11621920479/job/32367371250?pr=6298
The failure seems correctly captured as
timestamp
function returns timestamp of the sample so if certain samples are not trimmed then the result changes.I think the behavior is not intended but let's make disable chunk trimming a feature flag for now and users can enable it at their own risk
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]