Log query requests in QFE before query execution #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hassan <afayekhassan@gmail.com>
Signed-off-by: Ahmed Hassan <afayekhassan@gmail.com>
dosubot
bot
added
component/query-frontend
type/observability
alanprot
approved these changes
Dec 2, 2024
|
I'd like to add a bit more details on why it is useful to log query request before query execution. Query Frontend only logs query string along with query stats after processing the query request. If a query is expensive to process (for example, with very large response body size), query frontend might get OOM killed and unable to log the full query string, making it hard to debug the issue. Logging it before query execution should help gather the insights by correlating request ID and query string. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add logging for query requests in QFE before query execution. Query requests are logged only if
query_stats_enabledis enabled. This is useful for debugging queries that failed to return to QFE.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]