Skip to content

Commit

Permalink
Change how we set cmake policy (facebook#37349)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#37349

X-link: facebook/yoga#1288

Fixes facebook/yoga#1283

New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`.

Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions.

Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392

This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum.

Reviewed By: cortinico

Differential Revision: D45724864

fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7
  • Loading branch information
NickGerleman authored and facebook-github-bot committed May 15, 2023
1 parent 11251c3 commit 2b932c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# LICENSE file in the root directory of this source tree.


cmake_minimum_required(VERSION 3.13)
cmake_minimum_required(VERSION 3.13...3.26)
project(yogacore)
set(CMAKE_VERBOSE_MAKEFILE on)

Expand Down

0 comments on commit 2b932c3

Please sign in to comment.