Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble upgrading to react-native 0.3.10 #10

Closed
VonD opened this issue Apr 9, 2015 · 6 comments
Closed

Trouble upgrading to react-native 0.3.10 #10

VonD opened this issue Apr 9, 2015 · 6 comments

Comments

@VonD
Copy link

VonD commented Apr 9, 2015

Hi,

After upgrading react-native to 0.3.10 (from 0.3.4) the project build fails with the following : Did you forget to use RCT_EXPORT_MODULE() ? (see attachments). Downgrading back to 0.3.4 solves the issue.

Thank you.

capture d ecran 2015-04-09 a 18 57 56
capture d ecran 2015-04-09 a 18 40 59

@corymsmith
Copy link
Owner

Thanks for letting me know, I'll have to test that out as well!

@VonD
Copy link
Author

VonD commented Apr 10, 2015

just in case : facebook/react-native#793

@mikkoj
Copy link

mikkoj commented Apr 10, 2015

Adding RCT_EXPORT_MODULE() to all Manager-implementations in ReactNativeIcons-project made 0.3.10 work for me.

@dmnkgrc
Copy link

dmnkgrc commented Apr 10, 2015

@mikkoj worked for me too.

@corymsmith
Copy link
Owner

I'll fix this today, thanks everyone!

On Fri, Apr 10, 2015 at 6:08 AM, Dominik Garcia notifications@github.com
wrote:

@mikkoj worked for me too.

Reply to this email directly or view it on GitHub:
#10 (comment)

@corymsmith
Copy link
Owner

Fixed and pushed to NPM as version 0.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants