Update K8s.Conn.from_file to support fully qualified domain names (FQDN) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ref: coryodaniel#144 - I missed a codepath in the original PR that makes this not work with a call from K8s.Conn.from_file when using a FQDN for the server url.
|
@mruoss I feel like there should probably be an additional test for this as well, but we'd need to add a cluster fixture with a proper domain and TLS certificate. I am not certain that's worth the effort. Thoughts? |
|
All integration tests could connect to the cluster via FQDN, no? |
|
Maybe you can pull branch |
|
Ooooo that's clever, yeah let me give that a go tomorrow 👍🏻 |
Can you also update changelog.md? |
|
Yes I can add that as well. I did not quite get this finished today and I am about to be out of town until 6/20. Hoping to snag a few minutes to wrap up, but otherwise I will pickup when I get back. |
|
Any chance you could wrap this up anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
PKI.cert_from_map/2to support fully qualified domain names (FQDN)call from
K8s.Conn.from_file/1when using a FQDN for the server url.