Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slider for border radius #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ahoneybun
Copy link
Member

@ahoneybun ahoneybun commented Jul 17, 2024

This adds the option to change the border radius for the dock and panel.

@edfloreshz
Copy link
Member

It works, however, the elements inside the panel are not changing their border radius.

@ahoneybun
Copy link
Member Author

It works, however, the elements inside the panel are not changing their border radius.

It is for the outside of the panel not inside and I believe that is the same for the dock.

Co-authored-by: Eduardo Flores <edfloreshz@gmail.com>
@edfloreshz
Copy link
Member

edfloreshz commented Jul 17, 2024

Yes, but the panel ends up looking like this:

image

The border radius should also apply to the elements inside it, that's what cosmic-settings does.

image

@ahoneybun
Copy link
Member Author

Do we want to remove the option for the panel and only for the dock? COSMIC Settings does not show this option so I figured it was good for Tweaks for COSMIC.

@edfloreshz
Copy link
Member

Yeah, the option is great, we should just try to fix the issue before merging.

@ahoneybun
Copy link
Member Author

Is it an upstream issue or an us issue though?

@edfloreshz
Copy link
Member

It's an us issue as far as I can tell, you can look into cosmic-settings to see how the app updates the radius and replicate that here.

@ahoneybun
Copy link
Member Author

I don't see that option in Settings, is it just for the panel there?

@edfloreshz
Copy link
Member

This option changes the border radius of both the panels and the widgets.

image

@edfloreshz edfloreshz force-pushed the main branch 3 times, most recently from 521ee70 to f4dc232 Compare November 6, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants