the bot speaks! #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit more involved than anticipated.
The dialogflow library that was part of the /lib/ folder of the react project is now deprecated, and won't actually talk to the dialogflow API. The current implementation of the dialogflow library is intended for NodeJS servers, and as such doesn't get authentication right on the client side. (as per this git issue: googleapis/google-cloud-node#2933 (comment)). I tried the fix listed here but it's a bit fiddly, and non-ideal. Doesn't make a huge amount of sense when we'll eventually run our own server anyway.
To get around this, the project now uses a nodeJS server, which is started along with the app by running
npm run devNB this is gonna fail the netlify test I would assume because Netlify can't run a server?