Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat / add endo base64 support #654

Merged
merged 7 commits into from
Sep 17, 2024
Merged

feat / add endo base64 support #654

merged 7 commits into from
Sep 17, 2024

Conversation

j-yw
Copy link
Contributor

@j-yw j-yw commented Sep 14, 2024

This PR addresses #651

adds conditional logic to use base64 encoders from helper or @endo/base64 methods

I had to modify the type on UTILS otherwise it wont accept both options ImportObj | string from customize-utils. hope thats ok.

let me know if there's a better way to implement it.

@j-yw j-yw marked this pull request as draft September 14, 2024 10:36
@j-yw j-yw self-assigned this Sep 14, 2024
@j-yw j-yw marked this pull request as ready for review September 14, 2024 14:41
@j-yw j-yw requested a review from Zetazzz September 14, 2024 14:41
@j-yw j-yw changed the title feat / add endo base64 support [WIP] feat / add endo base64 support Sep 14, 2024
@j-yw j-yw changed the base branch from feat/local-decimal-supporting-bigint to main September 14, 2024 14:53
@Zetazzz Zetazzz merged commit 0f2d2d1 into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants