Allow for unsafe synchronous creation of Tendermint34Client and Tendermint35Client

[garrettparris]

Currently the only way to use init the query client is asynchronously. When loading up a webpage relying on this client, all queries must wait on the detectVersion async function to complete and only then can the app use the query client. I suggest adding an unsafe creation method to the TendermintClient classes that skips this async detectVersion function.

[garrettparris]

#1359
Relevant PR

[webmaster128]

The query we are doing there is very questionable anyways. Would be good to understand if it is still needed and why.

What's your primary motivation for the proposed change?

• Getting rid of the async constructions?
• Avoid having to wait for the network request?

I'd like to get this integrated in the main constructors and solve your issue at the same time. Adding more APIs is probably not necessary here.

[garrettparris]

on the existing create function there is the following comment

  public static async create(rpcClient: RpcClient): Promise<Tendermint34Client> {
    // For some very strange reason I don't understand, tests start to fail on some systems
    // (our CI) when skipping the status call before doing other queries. Sleeping a little
    // while did not help. Thus we query the version as a way to say "hi" to the backend,
    // even in cases where we don't use the result.

In my opinion, health checking should be something the developer adds and not something baked into the creation of the class. However, the above comment is why I opted to add its own creation method.

My primary motivations are to remove the async constructions and avoid waiting for the network request. Doing so will allow clients to query over grpc on load time rather than waiting for this async to resolve.

[garrettparris]

@webmaster128 any thoughts on this?

[webmaster128]

I tried removing the extra query again but it causes connection problems again.

In #1380 you see and approach where the version query is moves from .create to .connect. You can use create directly then. It's still async but resolves immediately without a network request. Would that solve your issue?