Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Authz queries to QueryClient #1089

Merged
merged 17 commits into from
Mar 16, 2022
Merged

Add Authz queries to QueryClient #1089

merged 17 commits into from
Mar 16, 2022

Conversation

msteiner96
Copy link
Member

Resolves #1080

webmaster128
webmaster128 reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Can we add a test for that? This won't work in simapp 42 but should be available in simapp 44.

packages/stargate/src/modules/authz/queries.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@msteiner96
Copy link
Member Author

@webmaster128 Regarding the tests: Is there already an example test case that I could query?

@webmaster128
Copy link
Member

@webmaster128 Regarding the tests: Is there already an example test case that I could query?

In packages/stargate/src/modules/gov/queries.spec.ts you see an example test where the test itself generates example data that can then be queried. We should have everything available to do something similar here and send a MsgGrant that creates a grant which can be found in the test.

webmaster128
webmaster128 reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just a few improvements.

packages/stargate/src/modules/authz/queries.spec.ts Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is strange with the merging. We have the diff from other PRs in here. If you want you can just ignore and I fix it when merging.

packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
packages/stargate/src/modules/authz/queries.spec.ts Outdated Show resolved Hide resolved
msteiner96 and others added 3 commits March 16, 2022 10:52
@msteiner96 @webmaster128
Update packages/stargate/src/modules/authz/queries.ts
bee3388 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/authz/queries.spec.ts
89b0ef0 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@msteiner96 @webmaster128
Update packages/stargate/src/modules/authz/queries.spec.ts
f45b520 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@webmaster128 webmaster128 merged commit 8763c88 into main Mar 16, 2022
@webmaster128 webmaster128 deleted the add-authz-queries branch March 16, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Authz queries to QueryClient
2 participants
@msteiner96 @webmaster128