use protobufjs as a devDep only #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Nice change, thank you!
But please note that the runtime dependency still exists in ts-proto generated code (see https://github.com/confio/cosmjs-types/blob/v0.5.0/package.json).
| @@ -4,7 +4,7 @@ import { Coin } from "cosmjs-types/cosmos/base/v1beta1/coin"; | |||
| import { TxBody } from "cosmjs-types/cosmos/tx/v1beta1/tx"; | |||
| import { Any } from "cosmjs-types/google/protobuf/any"; | |||
| import Long from "long"; | |||
| import protobuf from "protobufjs"; | |||
| import type protobuf from "protobufjs"; | |||
There was a problem hiding this comment.
Nice one, did not know this 💎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
protobufjsis used only for type information and running unit tests. Usingimport typeallows it to be demoted fromdependenciestodevDependencies, reducing this package's footprint significantly (and sidestepping various complaints generated by naive interpretations of the output ofnpm auditto boot).