Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Decimal can be constructed with a negative atomics #1188

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Fix Decimal can be constructed with a negative atomics #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f22e00
Fix `Decimal` can be constructed with a negative atomics
tien Jun 22, 2022
048169f
refactor: stricter check for non-negative integers
tien Jun 25, 2022
bd8c2b8
chore: update test & fix spelling
tien Jun 25, 2022
3175384
test: use exact string match for error
tien Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/math/src/decimal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ describe("Decimal", () => {
expect(Decimal.fromAtomics("44", 3).toString()).toEqual("0.044");
expect(Decimal.fromAtomics("44", 4).toString()).toEqual("0.0044");
});

it("throws for atomics that are not non-negative integers", () => {
expect(() => Decimal.fromAtomics("-1", 0)).toThrowError(
"Invalid string format. Only non-negative integers in decimal representation supported.",
);
});
});

describe("fromUserInput", () => {
Expand Down
6 changes: 6 additions & 0 deletions packages/math/src/decimal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ export class Decimal {
};

private constructor(atomics: string, fractionalDigits: number) {
if (!atomics.match(/^[0-9]+$/)) {
throw new Error(
"Invalid string format. Only non-negative integers in decimal representation supported.",
);
}

this.data = {
atomics: new BN(atomics),
fractionalDigits: fractionalDigits,
Expand Down