Don't call getCryptoModule in getSubtle #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvid this is step 1 from #1307 (comment) |
webmaster128
force-pushed
the
crypro-imports
branch
from
cbe75e1
to
7b32660
Compare
|
Released as part of 0.29.5 |
webmaster128
commented
Dec 20, 2022
Comment on lines
+27
to
+37
| // From Node.js 15 onwards, webcrypto is available in globalThis. | ||
| // In version 15 and 16 this was stored under the webcrypto key. | ||
| // With Node.js 17 it was moved to the same locations where browsers | ||
| // make it available. | ||
| // Loading `require("crypto")` here seems unnecessary since it only | ||
| // causes issues with bundlers and does not increase compatibility. | ||
|
|
||
| // Browsers and Node.js 17+ | ||
| let subtle: any | undefined = (globalThis as any)?.crypto?.subtle; | ||
| // Node.js 15+ | ||
| if (!subtle) subtle = (globalThis as any)?.crypto?.webcrypto?.subtle; |
There was a problem hiding this comment.
All those comments are wrong because they only apply to the Node.js REPL, not Node.js itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.