Add default stargaze amino types to cosmwasm client #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Mar 8, 2023
webmaster128
reviewed
Mar 8, 2023
Oops, forgot! On it. |
|
dang the linter was still not satisfied 😫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SigningStargazeClientexports its default registry types to be consumed by theSigningCosmWasmClient, with the wasm types added on top of the default registry. However, this was not being done for Amino types.This PR exports the
SigningStargateClient's default amino types to be consumed by theSigningCosmWasmClient, adding the wasm amino types on top, following the same pattern.We ran into this issue over at DAO DAO when someone tried to use
SigningCosmWasmClientto vote on a governance proposal. The PR to fix that is here: DA0-DA0/dao-dao-ui#1165...though ideally I can undo that fix once this PR is merged and published.