Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use omitDefault to fix Amino JSON converter for Instantiate2 #1509

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Nov 15, 2023

Brought up by Noah in https://twitter.com/noahsaso/status/1724157309310714315 – thank you!

@webmaster128 webmaster128 force-pushed the omitDefault-instantiate2 branch from c77f69b to cf1fd0b Compare November 15, 2023 11:41
@webmaster128 webmaster128 marked this pull request as ready for review November 15, 2023 12:01
@webmaster128 webmaster128 merged commit 8f8449d into main Nov 15, 2023
15 checks passed
@webmaster128 webmaster128 deleted the omitDefault-instantiate2 branch November 15, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant