Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devchains #520

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Update devchains #520

merged 3 commits into from
Nov 10, 2020

Conversation

willclarktech
Copy link
Contributor

@willclarktech willclarktech commented Nov 10, 2020 •
edited
Loading

Part 1 of #515

@willclarktech willclarktech added the WIP work in progress label Nov 10, 2020
@willclarktech willclarktech removed the WIP work in progress label Nov 10, 2020
@willclarktech willclarktech marked this pull request as ready for review November 10, 2020 15:59
webmaster128
webmaster128 reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

scripts/simapp/start.sh
@@ -4,7 +4,7 @@ command -v shellcheck > /dev/null && shellcheck "$0"

# Please keep this in sync with the Ports overview in HACKING.md
TENDERMINT_PORT_GUEST="26657"
TENDERMINT_PORT_HOST="26657"
TENDERMINT_PORT_HOST="26658"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the ports list in HACKING.md accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I did! What did I leave out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just didn't push the latest change.

webmaster128
webmaster128 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All there now, thanks

@willclarktech willclarktech added the automerge See mergify.io label Nov 10, 2020
@mergify mergify bot merged commit 8fe7eb5 into master Nov 10, 2020
@mergify mergify bot deleted the 515-devchains branch November 10, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
automerge See mergify.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willclarktech @webmaster128