-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement bip39 #966
Re-implement bip39 #966
Conversation
This should reduce the bundle size a lot as seen in #904: |
What else is needed here? Would be great to reduce build size. How best to help get this out of Draft? |
This is basically ready. I just got side-tracked and did not consider this a release blocker for 0.27.0. One thing I wanted to add is a pure-js implementation of pbkdf2 in order to support environments that do not have subtle or the Node.js crypto module. But we can also do a cry test and see if someone complains. |
7c25d1d
to
db1f39e
Compare
cceefae
to
011b00a
Compare
011b00a
to
0613989
Compare
0613989
to
656d35f
Compare
This partially reverts #804 (going back to our own implementation) and inlines much more bip39 functionality.