cosmos-sdk-rs: make Tx::find_by_hash use the /tx endpoint
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
force-pushed
the
cosmos-sdk-rs/simplify-tx-find-by-hash
branch
from
ec87a5a
to
a1ae55a
Compare
tony-iqlusion
force-pushed
the
cosmos-sdk-rs/simplify-tx-find-by-hash
branch
2 times, most recently
from
9fc5607
to
7ff2133
Compare
Notably this endpoint provides read-your-writes consistency with regard to transactions, whereas `/tx_search` does not. See also: tendermint/tendermint#6359
tony-iqlusion
force-pushed
the
cosmos-sdk-rs/simplify-tx-find-by-hash
branch
from
7ff2133
to
8c72a5c
Compare
|
This is now working locally for me now that informalsystems/tendermint-rs#948 was fixed upstream in tendermint-rs v0.22 |
The `/tx` endpoint is still sporadically returning a not found error: https://github.com/cosmos/cosmos-rust/pull/116/checks?check_run_id=3724891908 This adds back the polling behavior to try repeatedly if this occurs
|
@jkilpatr can I get a stamp for this? Unfortunately I wasn't able to eliminate the need to poll for the transaction in the tests. Perhaps there's a lingering issue with tendermint/tendermint#6359 However, the |
zmanian
approved these changes
Sep 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this endpoint provides read-your-writes consistency with regard to transactions, whereas
/tx_searchdoes not.See also: tendermint/tendermint#6359