Bump tendermint-rs dependencies to v0.39
#482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
Aug 8, 2024
Comment on lines
+3
to
+11
| - plugin: buf.build/community/neoeinstein-prost:v0.3.1 | ||
| out: . | ||
| opt: | ||
| - extern_path=.tendermint=::tendermint_proto::v0_34 | ||
| - plugin: buf.build/community/neoeinstein-tonic:v0.3.0 | ||
| out: . | ||
| opt: | ||
| - compile_well_known_types | ||
| - extern_path=.google.protobuf=::tendermint_proto::google::protobuf |
There was a problem hiding this comment.
@ash-burnt I more or less cargo culted this from #471 but couldn't actually get it to work, instead proto-build is using a regex substitution instead (see main.rs)
tony-iqlusion
force-pushed
the
tendermint/v0.39
branch
from
c081135
to
169dcbf
Compare
Also regenerates protos. This notably switches from sourcing the `google.protobuf` well-known types from the `prost-types` crate and using `tendermint-proto`'s definitions instead.
tony-iqlusion
force-pushed
the
tendermint/v0.39
branch
from
169dcbf
to
9861bf9
Compare
tony-iqlusion
commented
Aug 8, 2024
| @@ -5,3 +5,6 @@ members = [ | |||
| "cosmos-sdk-proto", | |||
| "cosmrs" | |||
| ] | |||
|
|
|||
| [patch.crates-io] | |||
| tendermint-proto = { git = "https://github.com/informalsystems/tendermint-rs" } | |||
There was a problem hiding this comment.
This required a few upstream changes to tendermint-proto which should be released soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also regenerates protos.
This notably switches from sourcing the
google.protobufwell-known types from theprost-typescrate and usingtendermint-proto's definitions instead.See also: informalsystems/tendermint-rs#1452