Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oracle tutorial for Vote Extensions #93

Closed
wants to merge 2 commits into from

Conversation

samricotta
Copy link
Contributor

This is another tutorial for vote extensions but more advanced as we expect them to have their own chain etc. The snippets is based off the oracle repo https://github.com/facundomedica/oracle/tree/main and similar to the mitigation of auction front-running tutorial, this repo will be moved to sdk-tutorials-repo

Closes: #92

@samricotta samricotta changed the base branch from main to sam/tutorials November 29, 2023 15:12
@samricotta samricotta marked this pull request as ready for review November 29, 2023 15:24
@tac0turtle
Copy link
Member

why does this live here instead of the tutorial repo?


## Implement ExtendVote

First we’ll create the `OracleVoteExtension` struct, this is the object that will be marshaled as bytes and signed by the validator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where am i suppose to create this? are there prerequisites to starting this tutorial? repos to clone, files to create ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pre-requisites are:

In this tutorial, we expect the reader to have a chain project already working as we won’t go through the steps of creating a new chain/module.

We also assume you are already familiar with the Cosmos SDK, if you are not we suggest you start with [https://tutorials.cosmos.network](https://tutorials.cosmos.network), as ABCI++ is considered an advanced topic.


## Overview of the project

We’ll go through the creation of a simple price oracle module focusing on the vote extensions implementation, ignoring the details inside the price oracle itself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to what an oracle is


In this tutorial, we expect the reader to have a chain project already working as we won’t go through the steps of creating a new chain/module.

We also assume you are already familiar with the Cosmos SDK, if you are not we suggest you start with [https://tutorials.cosmos.network](https://tutorials.cosmos.network), as ABCI++ is considered an advanced topic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a link to what vote extensions are?

Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!!

@samricotta samricotta closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate workshop steps to tutorials - Oracle
3 participants