fix: remove 0 length check in pebble (#23157)

cosmos · Jan 2, 2025 · 3d544c1 · 3d544c1
1 parent 87c7e5e
commit 3d544c1
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 442 deletions.
diff --git a/store/v2/commitment/store_bench_test.go b/store/v2/commitment/store_bench_test.go
@@ -1,6 +1,3 @@
-//go:build rocksdb
-// +build rocksdb
-
 package commitment_test
 
 import (
@@ -20,9 +17,6 @@ import (
 var (
 	storeKeys  = []string{"store1", "store2", "store3"}
 	dbBackends = map[string]func(dataDir string) (corestore.KVStoreWithBatch, error){
-		"rocksdb_opts": func(dataDir string) (corestore.KVStoreWithBatch, error) {
-			return dbm.NewRocksDB("test", dataDir)
-		},
 		"pebbledb_opts": func(dataDir string) (corestore.KVStoreWithBatch, error) {
 			return dbm.NewPebbleDB("test", dataDir)
 		},

diff --git a/store/v2/db/db.go b/store/v2/db/db.go
@@ -11,7 +11,6 @@ type DBType string
 
 const (
 	DBTypeGoLevelDB DBType = "goleveldb"
-	DBTypeRocksDB   DBType = "rocksdb"
 	DBTypePebbleDB  DBType = "pebbledb"
 	DBTypePrefixDB  DBType = "prefixdb"
 

diff --git a/store/v2/db/pebbledb.go b/store/v2/db/pebbledb.go
@@ -72,10 +72,6 @@ func (db *PebbleDB) Get(key []byte) ([]byte, error) {
 		return nil, fmt.Errorf("failed to perform PebbleDB read: %w", err)
 	}
 
-	if len(bz) == 0 {
-		return nil, closer.Close()
-	}
-
 	return bz, closer.Close()
 }
 

diff --git a/store/v2/db/rocksdb.go b/store/v2/db/rocksdb.go