Merge branch 'main' into julien/autocli

cosmos · Jun 17, 2024 · 9afc58e · 9afc58e
2 parents 0069483 + 6d2f6ff
commit 9afc58e
Show file tree

Hide file tree

Showing 901 changed files with 57,846 additions and 24,065 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -14,7 +14,18 @@ please add links to any relevant follow up issues.*
 
 I have...
 
-* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
+* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title, you can find examples of the prefixes below:
+    <!-- * `feat`: A new feature
+    * `fix`: A bug fix
+    * `docs`: Documentation only changes
+    * `style`: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
+    * `refactor`: A code change that neither fixes a bug nor adds a feature
+    * `perf`: A code change that improves performance
+    * `test`: Adding missing tests or correcting existing tests
+    * `build`: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
+    * `ci`: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
+    * `chore`: Other changes that don't modify src or test files
+    * `revert`: Reverts a previous commit -->
 * [ ] confirmed `!` in the type prefix if API or client breaking change
 * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
 * [ ] provided a link to the relevant issue or specification
@@ -29,6 +40,8 @@ I have...
 *All items are required. Please add a note if the item is not applicable and please add
 your handle next to the items reviewed if you only reviewed selected items.*
 
+Please see [Pull Request Reviewer section in the contributing guide](../CONTRIBUTING.md#reviewer) for more information on how to review a pull request.
+
 I have...
 
 * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title

diff --git a/.github/PULL_REQUEST_TEMPLATE/docs.md b/.github/PULL_REQUEST_TEMPLATE/docs.md
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -61,6 +61,15 @@ updates:
     labels:
       - "A:automerge"
       - dependencies
+  - package-ecosystem: gomod
+    directory: "/core/testing"
+    schedule:
+      interval: weekly
+      day: thursday
+      time: "01:30"
+    labels:
+      - "A:automerge"
+      - dependencies
   - package-ecosystem: gomod
     directory: "/depinject"
     schedule:

diff --git a/.github/pr_labeler.yml b/.github/pr_labeler.yml
@@ -16,6 +16,8 @@
   - store/**/*
 "C:collections":
   - collections/**/*
+"C:core/testing":
+  - core/testing/**/*
 "C:log":
   - log/*
 "C:orm":

diff --git a/.github/workflows/pr-go-mod-tidy-mocks.yml b/.github/workflows/pr-go-mod-tidy-mocks.yml
@@ -0,0 +1,52 @@
+name: "Checks dependencies and mocks generation"
+on:
+  merge_group:
+  pull_request:
+  push:
+    branches:
+      - main
+
+concurrency:
+  group: ci-${{ github.ref }}-pr-go-mod-tidy-mocks
+  cancel-in-progress: true
+
+jobs:
+  go-mod-tidy:
+    name: Check go mod tidy
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.22"
+          check-latest: true
+      - name: Run go mod tidy
+        run: ./scripts/go-mod-tidy-all.sh
+      - name: Check for diffs
+        run: |
+          git diff --exit-code || {
+            echo "Please run './scripts/go-mod-tidy-all.sh' and commit the changes";
+            exit 1;
+          }
+
+  generate-mocks:
+    name: Check up to date mocks
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.22"
+          check-latest: true
+      - name: Generate mocks
+        run: make mocks
+      - name: Check for diffs
+        run: |
+          git diff --exit-code || {
+            echo "Please run 'make mocks' and commit the changes";
+            exit 1;
+          }
diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml
@@ -15,7 +15,7 @@ jobs:
     timeout-minutes: 5
     steps:
       - uses: actions/checkout@v4
-      - uses: bufbuild/buf-setup-action@v1.31.0
+      - uses: bufbuild/buf-setup-action@v1.33.0
       - uses: bufbuild/buf-lint-action@v1
         with:
           input: "proto"
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: bufbuild/buf-setup-action@v1.31.0
+      - uses: bufbuild/buf-setup-action@v1.33.0
       - uses: bufbuild/buf-breaking-action@v1
         with:
           input: "proto"

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -184,10 +184,10 @@ jobs:
           name: "testnet-setup"
           path: ./systemtests/testnet/
           retention-days: 3
-      #      - name: system tests v2
-      #        if: env.GIT_DIFF
-      #        run: |
-      #          make test-system
+      - name: system tests v2
+        if: env.GIT_DIFF
+        run: |
+          make test-system
       - uses: actions/upload-artifact@v3
         if: failure()
         with:
@@ -241,37 +241,6 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
-  liveness-test:
-    runs-on: ubuntu-latest
-    timeout-minutes: 15
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version: "1.22"
-          check-latest: true
-          cache: true
-          cache-dependency-path: go.sum
-      - uses: technote-space/get-diff-action@v6.1.2
-        id: git_diff
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
-            **/go.mod
-            **/go.sum
-            **/Makefile
-            Makefile
-      - name: start localnet
-        if: env.GIT_DIFF
-        run: |
-          make clean localnet-start
-      - name: test liveness
-        if: env.GIT_DIFF
-        run: |
-          ./contrib/localnet_liveness.sh 100 5 50 localhost
-
   test-sim-nondeterminism:
     runs-on: ubuntu-latest
     steps:
@@ -366,6 +335,36 @@ jobs:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:
           projectBaseDir: core/
+  test-coretesting:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: "1.20"
+          check-latest: true
+          cache: true
+          cache-dependency-path: core/testing/go.sum
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
+        with:
+          PATTERNS: |
+            core/testing/**/*.go
+            core/testing/go.mod
+            core/testing/go.sum
+      - name: tests
+        if: env.GIT_DIFF
+        run: |
+          cd core/testing
+          go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock' ./...
+      - name: sonarcloud
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          projectBaseDir: core/testing/
 
   test-depinject:
     runs-on: ubuntu-latest
@@ -485,14 +484,6 @@ jobs:
         run: |
           cd simapp
           go test -mod=readonly -timeout 30m -tags='app_v1 norace ledger test_ledger_mock' ./...
-      - name: sonarcloud
-        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
-        uses: SonarSource/sonarcloud-github-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-        with:
-          projectBaseDir: simapp/
 
   test-collections:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/v2-test.yml b/.github/workflows/v2-test.yml
@@ -37,3 +37,27 @@ jobs:
         if: env.GIT_DIFF
         run: |
           cd server/v2/stf && go test -mod=readonly -race -timeout 30m -covermode=atomic -tags='ledger test_ledger_mock'
+          
+  appamanger:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: "1.22"
+          check-latest: true
+          cache: true
+          cache-dependency-path: go.sum
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
+        with:
+          PATTERNS: |
+            server/v2/appmanager/**/*.go
+            server/v2/appmanager/go.mod
+            server/v2/appmanager/go.sum
+      - name: test & coverage report creation
+        if: env.GIT_DIFF
+        run: |
+          cd server/v2/appmanager && go test -mod=readonly -race -timeout 30m -covermode=atomic -tags='ledger test_ledger_mock'
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,19 +1,8 @@
 run:
   tests: true
   timeout: 15m
-  sort-results: true
   allow-parallel-runners: true
-  exclude-dir: testutil/testdata
-  skip-files:
-    - server/grpc/gogoreflection/fix_registration.go
-    - "fix_registration.go"
-    - ".*\\.pb\\.go$"
-    - ".*\\.pb\\.gw\\.go$"
-    - ".*\\.pulsar\\.go$"
-    - crypto/keys/secp256k1/internal/*
-    - types/coin_regex.go
-
-build-tags:
+  build-tags:
   - e2e
   - ledger
   - test_ledger_mock
@@ -24,6 +13,7 @@ linters:
   enable:
     - dogsled
     - errcheck
+    - errorlint
     - exportloopref
     - gci
     - goconst
@@ -45,6 +35,16 @@ linters:
     - unused
 
 issues:
+  exclude-dirs: 
+    - testutil/testdata
+  exclude-files:
+    - server/grpc/gogoreflection/fix_registration.go
+    - "fix_registration.go"
+    - ".*\\.pb\\.go$"
+    - ".*\\.pb\\.gw\\.go$"
+    - ".*\\.pulsar\\.go$"
+    - crypto/keys/secp256k1/internal/*
+    - types/coin_regex.go
   exclude-rules:
     - text: "Use of weak random number generator"
       linters:
@@ -140,11 +140,8 @@ linters-settings:
     extra-rules: true
   dogsled:
     max-blank-identifiers: 6
-  maligned:
-    suggest-new: true
   nolintlint:
     allow-unused: false
-    allow-leading-space: true
     require-explanation: true
     require-specific: false
   gosimple: