Skip to content

Commit

Permalink
test: Added tests for DecCoins to increase code coverage (#9752)
Browse files Browse the repository at this point in the history
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Ref: #7031 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

Note/todo : 
1. Not sure if [this](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin.go#L631) line is reachable. The condition is already checked in [this ](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin.go#L618) line. Therefore, 100% coverage for `ParseDecCoin` function likely not possible
2. Clarification needed [here](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin_test.go#L883-L884)
3. Clarification needed [here](https://github.com/cosmos/cosmos-sdk/blob/spoorthi/7031-deccoins-adding-tests/types/dec_coin_test.go#L1124-L1125)

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
  • Loading branch information
spoo-bar authored Jul 26, 2021
1 parent 3771ebd commit b34ceec
Show file tree
Hide file tree
Showing 2 changed files with 566 additions and 3 deletions.
1 change: 1 addition & 0 deletions container/option_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package container_test
Loading

0 comments on commit b34ceec

Please sign in to comment.