Merge branch 'main' into marko/move-pruning

.github/dependabot.yml

@@ -56,7 +56,7 @@ updates:
       - "A:automerge"
       - dependencies
   - package-ecosystem: gomod
-    directory: "/cosmovisor"
+    directory: "/tools/cosmovisor"
     schedule:
       interval: weekly
     labels:
@@ -90,13 +90,6 @@ updates:
     labels:
       - "A:automerge"
       - dependencies
-  - package-ecosystem: gomod
-    directory: "/store/tools/ics23"
-    schedule:
-      interval: weekly
-    labels:
-      - "A:automerge"
-      - dependencies
   - package-ecosystem: gomod
     directory: "/tx"
     schedule:

.github/workflows/cosmovisor-release.yml

@@ -34,7 +34,7 @@ jobs:
           # stick to version v0.179.0(https://github.com/cosmos/cosmos-sdk/issues/11125)
           version: v0.179.0
           args: release --rm-dist --skip-validate
-          workdir: cosmovisor
+          workdir: tools/cosmovisor
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GORELEASER_CURRENT_TAG: cosmovisor/${{ env.RELEASE_VERSION }}

CHANGELOG.md

@@ -53,9 +53,11 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/bank) [#11981](https://github.com/cosmos/cosmos-sdk/pull/11981) Create the `SetSendEnabled` endpoint for managing the bank's SendEnabled settings.
 * (x/auth) [#13210](https://github.com/cosmos/cosmos-sdk/pull/13210) Add `Query/AccountInfo` endpoint for simplified access to basic account info.
 * (x/consensus) [#12905](https://github.com/cosmos/cosmos-sdk/pull/12905) Create a new `x/consensus` module that is now responsible for maintaining Tendermint consensus parameters instead of `x/param`. Legacy types remain in order to facilitate parameter migration from the deprecated `x/params`. App developers should ensure that they execute `baseapp.MigrateParams` during their chain upgrade. These legacy types will be removed in a future release.
+* (x/auth) [#13612](https://github.com/cosmos/cosmos-sdk/pull/13612) Add `Query/ModuleAccountByName` endpoint for accessing the module account info by module name.
 
 ### Improvements
 
+* (tools) [#13603](https://github.com/cosmos/cosmos-sdk/pull/13603) Rename cosmovisor package name to `cosmossdk.io/tools/cosmovisor`. The new tool directory contains Cosmos SDK tools.
 * (deps) [#13397](https://github.com/cosmos/cosmos-sdk/pull/13397) Bump Go version minimum requirement to `1.19`.
 * [#13070](https://github.com/cosmos/cosmos-sdk/pull/13070) Migrate from `gogo/protobuf` to `cosmos/gogoproto`.
 * [#12995](https://github.com/cosmos/cosmos-sdk/pull/12995) Add `FormatTime` and `ParseTimeString` methods.

Makefile

@@ -138,7 +138,7 @@ $(BUILDDIR)/:
 	mkdir -p $(BUILDDIR)/
 
 cosmovisor:
-	$(MAKE) -C cosmovisor cosmovisor
+	$(MAKE) -C tools/cosmovisor cosmovisor
 
 .PHONY: build build-linux-amd64 build-linux-arm64 cosmovisor
 

contrib/images/simd-dlv/Dockerfile

@@ -10,7 +10,6 @@ COPY math/go.mod math/go.sum /work/math/
 COPY api/go.mod api/go.sum /work/api/
 COPY core/go.mod core/go.sum /work/core/
 COPY depinject/go.mod depinject/go.sum /work/depinject/
-COPY store/tools/ics23/go.mod store/tools/ics23/go.sum /work/store/tools/ics23/
 
 RUN go mod download
 COPY ./ /work

contrib/images/simd-env/Dockerfile

@@ -9,7 +9,6 @@ COPY math/go.mod math/go.sum /work/math/
 COPY api/go.mod api/go.sum /work/api/
 COPY core/go.mod core/go.sum /work/core/
 COPY depinject/go.mod depinject/go.sum /work/depinject/
-COPY store/tools/ics23/go.mod store/tools/ics23/go.sum /work/store/tools/ics23/
 
 RUN go mod download
 COPY ./ /work

core/appmodule/module.go

@@ -0,0 +1,14 @@
+package appmodule
+
+import "cosmossdk.io/depinject"
+
+// AppModule is a tag interface for app module implementations to use as a basis
+// for extension interfaces. It provides no functionality itself, but is the
+// type that all valid app modules should provide so that they can be identified
+// by other modules (usually via depinject) as app modules.
+type AppModule interface {
+	depinject.OnePerModuleType
+
+	// IsAppModule is a dummy method to tag a struct as implementing an AppModule.
+	IsAppModule()
+}

core/coins/format.go

@@ -44,17 +44,15 @@ func formatCoin(coin *basev1beta1.Coin, metadata *bankv1beta1.Metadata) (string,
 		return vr + " " + coin.Denom, err
 	}
 
-	exponentDiff := int64(coinExp) - int64(dispExp)
-
 	dispAmount, err := math.LegacyNewDecFromStr(coin.Amount)
 	if err != nil {
 		return "", err
 	}
 
-	if exponentDiff > 0 {
-		dispAmount = dispAmount.Mul(math.LegacyNewDec(10).Power(uint64(exponentDiff)))
+	if coinExp > dispExp {
+		dispAmount = dispAmount.Mul(math.LegacyNewDec(10).Power(uint64(coinExp - dispExp)))
 	} else {
-		dispAmount = dispAmount.Quo(math.LegacyNewDec(10).Power(uint64(-exponentDiff)))
+		dispAmount = dispAmount.Quo(math.LegacyNewDec(10).Power(uint64(dispExp - coinExp)))
 	}
 
 	vr, err := math.FormatDec(dispAmount.String())

core/go.mod

@@ -21,7 +21,7 @@ require (
 	github.com/kr/text v0.2.0 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/exp v0.0.0-20220827204233-334a2380cb91 // indirect
+	golang.org/x/exp v0.0.0-20221019170559-20944726eadf // indirect
 	golang.org/x/net v0.0.0-20221017152216-f25eb7ecb193 // indirect
 	golang.org/x/sys v0.0.0-20221013171732-95e765b1cc43 // indirect
 	golang.org/x/text v0.3.8 // indirect

core/go.sum

@@ -39,8 +39,8 @@ github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9dec
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
-golang.org/x/exp v0.0.0-20220827204233-334a2380cb91 h1:tnebWN09GYg9OLPss1KXj8txwZc6X6uMr6VFdcGNbHw=
-golang.org/x/exp v0.0.0-20220827204233-334a2380cb91/go.mod h1:cyybsKvd6eL0RnXn6p/Grxp8F5bW7iYuBgsNCOHpMYE=
+golang.org/x/exp v0.0.0-20221019170559-20944726eadf h1:nFVjjKDgNY37+ZSYCJmtYf7tOlfQswHqplG2eosjOMg=
+golang.org/x/exp v0.0.0-20221019170559-20944726eadf/go.mod h1:cyybsKvd6eL0RnXn6p/Grxp8F5bW7iYuBgsNCOHpMYE=
 golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=

docs/architecture/adr-050-sign-mode-textual-annex2.md

@@ -16,7 +16,7 @@ This annex provides normative guidance on how devices should render a
 ## Context
 
 `SIGN_MODE_TEXTUAL` allows a legible version of a transaction to be signed
-on a hardware security devices, such as a Ledger. Early versions of the
+on a hardware security device, such as a Ledger. Early versions of the
 design rendered transactions directly to lines of ASCII text, but this
 proved awkward from its in-band signaling, and for the need to display
 Unicode text within the transaction.
@@ -53,13 +53,13 @@ sequence, with user controls for going forward or backward a line.
 - Expert mode screens are only presented if the device is in expert mode.
 
 - Each line of the screen starts with a number of `>` characters equal
-to the screen's indetation level, followed by a `+` character if this
+to the screen's indentation level, followed by a `+` character if this
 isn't the first line of the screen, followed by a space if either a
 `>` or a `+` has been emitted,
 or if this header is followed by a `>`, `+`, or space.
 
-- If the line ends with whitespace or an `@` character, and `@` character
-is appended to the line.
+- If the line ends with whitespace or an `@` character, an additional `@`
+character is appended to the line.
 
 - The following ASCII control characters or backslash (`\`) are converted
 to a backslash followed by a letter code, in the manner of string literals

docs/architecture/adr-050-sign-mode-textual.md

@@ -229,7 +229,7 @@ When this option is set on a `Msg`, a registered function will transform the `Ms
 
 The `<unique algorithm identifier>` is a string convention chosen by the application developer and is used to identify the custom `Msg` renderer. For example, the documentation or specification of this custom algorithm can reference this identifier. This identifier CAN have a versioned suffix (e.g. `_v1`) to adapt for future changes (which would be consensus-breaking). We also recommend adding Protobuf comments to describe in human language the custom logic used.
 
-Moreover, the renderer must provide 2 functions: one for formatting from Protobuf to string, and one for parsing string to Protobuf. These 2 functions are provided by the application developer. To satisfy point #1, these 2 functions MUST be bijective with each other. Bijectivity of these 2 functions will not be checked by the SDK at runtime. However, we strongly recommend the application developer to include a comprehensive suite in their app repo to test bijectivity, as to not introduce security bugs.
+Moreover, the renderer must provide 2 functions: one for formatting from Protobuf to string, and one for parsing string to Protobuf. These 2 functions are provided by the application developer. To satisfy point #1, the parse function MUST be the inverse of the formatting function. This property will not be checked by the SDK at runtime. However, we strongly recommend the application developer to include a comprehensive suite in their app repo to test invertibility, as to not introduce security bugs.
 
 ### Require signing over the `TxBody` and `AuthInfo` raw bytes
 
@@ -244,7 +244,7 @@ where:
 - `HEX` is the hexadecimal representation of the bytes, all in capital letters, no `0x` prefix,
 - and `len()` is encoded as a Big-Endian uint64.
 
-This is to prevent transaction hash malleability. The point #1 about bijectivity assures that transaction `body` and `auth_info` values are not malleable, but the transaction hash still might be malleable with point #1 only, because the SIGN_MODE_TEXTUAL strings don't follow the byte ordering defined in `body_bytes` and `auth_info_bytes`. Without this hash, a malicious validator or exchange could intercept a transaction, modify its transaction hash _after_ the user signed it using SIGN_MODE_TEXTUAL (by tweaking the byte ordering inside `body_bytes` or `auth_info_bytes`), and then submit it to Tendermint.
+This is to prevent transaction hash malleability. The point #1 about invertiblity assures that transaction `body` and `auth_info` values are not malleable, but the transaction hash still might be malleable with point #1 only, because the SIGN_MODE_TEXTUAL strings don't follow the byte ordering defined in `body_bytes` and `auth_info_bytes`. Without this hash, a malicious validator or exchange could intercept a transaction, modify its transaction hash _after_ the user signed it using SIGN_MODE_TEXTUAL (by tweaking the byte ordering inside `body_bytes` or `auth_info_bytes`), and then submit it to Tendermint.
 
 By including this hash in the SIGN_MODE_TEXTUAL signing payload, we keep the same level of guarantees as [SIGN_MODE_DIRECT](./adr-020-protobuf-transaction-encoding.md).
 

docs/package.json

@@ -31,7 +31,7 @@
     "prism-react-renderer": "^1.3.5",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
-    "tailwindcss": "^3.1.8"
+    "tailwindcss": "^3.2.0"
   },
   "devDependencies": {
     "@docusaurus/module-type-aliases": "2.1.0"

docs/pre.sh

@@ -21,7 +21,7 @@ cp -r ../x/auth/vesting/README.md ./docs/modules/vesting/README.md
 cat ../x/README.md | sed 's/\.\.\/docs\/building-modules\/README\.md/\/building-modules\/intro\.html/g' > ./docs/modules/README.md
 
 ## Add Cosmovisor documentation
-cp ../cosmovisor/README.md ./docs/tooling/01-cosmovisor.md
+cp ../tools/cosmovisor/README.md ./docs/tooling/01-cosmovisor.md
 
 ## Add depinject documentation
 cp ../depinject/README.md ./docs/building-apps/01-depinject.md