remove test boolean flag from NewKeybaseKeyring

client/keys/migrate.go

@@ -47,7 +47,7 @@ func runMigrateCmd(cmd *cobra.Command, args []string) error {
 	if viper.GetBool(flags.FlagDryRun) {
 		keyring = keys.NewTestKeybaseKeyring(types.GetConfig().GetKeyringServiceName(), rootDir)
 	} else {
-		keyring = keys.NewKeybaseKeyring(types.GetConfig().GetKeyringServiceName(), rootDir, buf, false)
+		keyring = keys.NewKeybaseKeyring(types.GetConfig().GetKeyringServiceName(), rootDir, buf)
 	}
 
 	for _, key := range oldKeys {

crypto/keys/lazy_keybase_keyring.go

@@ -34,18 +34,19 @@ type lazyKeybaseKeyring struct {
 
 // NewKeybaseKeyring creates a new instance of a lazy keybase using a Keyring as
 // the persistence layer.
-func NewKeybaseKeyring(name string, dir string, userInput io.Reader, test bool) Keybase {
+func NewKeybaseKeyring(name string, dir string, userInput io.Reader) Keybase {
 	_, err := keyring.Open(keyring.Config{
 		ServiceName: name,
 	})
 	if err != nil {
 		panic(err)
 	}
 
-	return lazyKeybaseKeyring{name: name, dir: dir, userInput: userInput, test: test}
+	return lazyKeybaseKeyring{name: name, dir: dir, userInput: userInput, test: false}
 }
 
-// New creates a new instance of a lazy keybase.
+// NewTestKeybaseKeyring creates a new instance of a keyring keybase
+// for testing purposes that  does not prompt users for password.
 func NewTestKeybaseKeyring(name string, dir string) Keybase {
 	if _, err := keyring.Open(keyring.Config{
 		AllowedBackends: []keyring.BackendType{"file"},