Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: No documentation on using hooks #10453

Open
jtremback opened this issue Oct 28, 2021 · 8 comments
Open

Documentation: No documentation on using hooks #10453

jtremback opened this issue Oct 28, 2021 · 8 comments
Assignees
Labels
good first issue T:Docs Changes and features related to documentation.

Comments

@jtremback
Copy link
Contributor

Some modules have hooks, and in the docs they tend to have a list of the names of all the hooks. What is missing is a guide on how one can connect to hooks.

@GauravDhak
Copy link

Hye @jtremback i want to work on this issue /assign

@julienrbrt
Copy link
Member

Awesome, thank you!

@GauravDhak
Copy link

hey @jtremback i need more clarification to work

@julienrbrt
Copy link
Member

Modules like staking, gov or distribution have hooks.
The staking hooks docs for instance, are very minimal and the gov one are not existing, we should make them as good as for distribution.

@julienrbrt
Copy link
Member

@GauravDhak are you still up to work on this issue?

@julienrbrt
Copy link
Member

Let's add a note in the gov hooks docs as well the following:

AfterProposalFailedMinDeposit and AfterProposalVotingPeriodEnded GovHooks should be not resource intensive

(A-39)

@Paulius0112
Copy link

@julienrbrt can I work on this issue?

@julienrbrt
Copy link
Member

@julienrbrt can I work on this issue?

Yes, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T:Docs Changes and features related to documentation.
Projects
No open projects
Development

No branches or pull requests

6 participants