Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/gov)!: let hooks return an error #18173

Merged
merged 2 commits into from
Oct 19, 2023
Merged

refactor(x/gov)!: let hooks return an error #18173

merged 2 commits into from
Oct 19, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 19, 2023 •
edited
Loading

Description

A-9

No fix for v0.47 as we cannot introduce an api breaking change and cannot know if the hook failed.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner October 19, 2023 09:23
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 19, 2023
julienrbrt
julienrbrt commented Oct 19, 2023
View reviewed changes
CHANGELOG.md
@@ -74,6 +74,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking Changes

* (x/gov) [#18173](https://github.com/cosmos/cosmos-sdk/pull/18173) Gov Hooks now returns error and are "blocking" if they fail. Expect for `AfterProposalFailedMinDeposit` and `AfterProposalVotingPeriodEnded` that will log the error and continue.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to be explained when this is done: #10453

tac0turtle
tac0turtle approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we open an issue to return errors on all hooks?

@julienrbrt
Copy link
Member Author

should we open an issue to return errors on all hooks?

Can do here too if you want, but I think they already do 🤔

@tac0turtle tac0turtle added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 4121869 Oct 19, 2023
51 checks passed
@tac0turtle tac0turtle deleted the julien/gov-hooks branch October 19, 2023 13:01
mergify bot pushed a commit that referenced this pull request Oct 19, 2023
@julienrbrt @mergify
refactor(x/gov)!: let hooks return an error (#18173)
b501f4c 
(cherry picked from commit 4121869)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Oct 19, 2023
Merged
@julienrbrt
Copy link
Member Author

should we open an issue to return errors on all hooks?

Can do here too if you want, but I think they already do 🤔

Just checked, and they indeed all do, only gov was missing.

tac0turtle pushed a commit that referenced this pull request Oct 19, 2023
@mergify @julienrbrt
refactor(x/gov)!: let hooks return an error (backport #18173) (#18174)
faca3c1 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@dusan-maksimovic dusan-maksimovic mentioned this pull request Jan 31, 2024
Merged
12 tasks
mpoke pushed a commit that referenced this pull request Feb 1, 2024
@dusan-maksimovic
fix(x/gov): Backport of pull request #18173 to feature/v.0.47.x-ics-l…
f6bf231 
…sm branch (#19305)
mattverse pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 6, 2024
@dusan-maksimovic @mattverse
fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x…
3168764 
…-ics-lsm branch (cosmos#19305)
czarcas7ic added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 9, 2024
@mattverse @dusan-maksimovic @czarcas7ic
(Backport) fix(x/gov): let hooks return an error (#514)
c2363b6 
* fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x-ics-lsm branch (cosmos#19305)

* update changelog

---------

Co-authored-by: Dusan Maksimovic <94966669+dusan-maksimovic@users.noreply.github.com>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @facundomedica @tac0turtle