Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/gov)!: let hooks return an error (backport #18173) #18174

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2023

This is an automatic backport of pull request #18173 done by Mergify.
Cherry-pick of 4121869 has failed:

On branch mergify/bp/release/v0.50.x/pr-18173
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 4121869cb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/gov/abci.go
	modified:   x/gov/keeper/deposit.go
	modified:   x/gov/keeper/hooks_test.go
	modified:   x/gov/keeper/proposal.go
	modified:   x/gov/keeper/vote.go
	modified:   x/gov/types/expected_keepers.go
	modified:   x/gov/types/hooks.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 4121869)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner October 19, 2023 13:02
@mergify mergify bot added the conflicts label Oct 19, 2023
@tac0turtle tac0turtle merged commit faca3c1 into release/v0.50.x Oct 19, 2023
48 checks passed
@tac0turtle tac0turtle deleted the mergify/bp/release/v0.50.x/pr-18173 branch October 19, 2023 13:55
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants