Events for failed transactions

[Vritra4]

Summary of Bug

• Events for failed transactions are empty although there's some fees paid.

Problem Definition

for failed transactions

Successful transactions have events about fee.
But failed transactions like below are have no events although there's some fees paid.
I think failed transactions also should have events about fee.

      {
        "code": 11,
        "data": null,
        "log": "out of gas in location: WritePerByte; gasWanted: 1069927, gasUsed: 1071169: out of gas",
        "info": "",
        "gas_wanted": "1069927",
        "gas_used": "1071169",
        "events": [],
        "codespace": "sdk"
      },

Version

v0.44.2

Steps to Reproduce

1. invoke a Tx to be failed
2. query Tx info

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[tac0turtle]

DOnt see why a reason not to do this, would you be open to submitting a PR?

[alexanderbez]

This is because we do not return an *sdk.Result if runMsgs fails. Returning events for a failed tx would break the non-nil semantics of *sdk.Result here. Not say this can't be done, but rather it wasn't done on purpose.

[yun-yeo]

The purpose of this is for rosetta reconciliation test.

It requires to track whole tx balance changes including failed txs, which still spending fee but there is no tx events left. Due to absent of event logs, this reconciliation test continually failed when the account has failed tx.

[alexanderbez]

Yes, I totally understand the motivation -- I'm just stating why it wasn't done. Returning events as a separate value works, albeit I don't think it's the cleanest solution, but it works.

[ghost]

Doesnt this get addressed via #10630?

[alexanderbez]

Doesnt this get addressed via #10630?

No, #10630 add Events to the response type -- this has the effect of including both message-related events and non-message related events (i.e. ante-handler).

This PR supports including events for failed txs.

[ghost]

Ahh, that makes sense.

[jim423]

Hi, may I ask what the /txs API of querying for failed txs by ante events looks like?