fix: Add Events to TxResponse

[alexanderbez]

Description

Closes: #10277

Add a new Events field to the TxResponse. Note, this somewhat clobbers with the existing Logs field and can cause some confusion, but regardless, we should have the actual events included.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

@AmauryM or @marbar3778, do you know why running make proto-all or make proto-gen seems to generate the wrong diff? I'd expect only the abci files to change, however, running any two of those commands yields the following diff:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   client/grpc/tmservice/query.pb.go
        modified:   crypto/hd/hd.pb.go
        modified:   docs/core/proto-docs.md
        modified:   go.mod
        modified:   go.sum
        modified:   orm/internal/testpb/testschema.proto
        modified:   proto/cosmos/gov/v1beta2/tx.proto
        modified:   proto/cosmos/tx/v1beta1/tx.proto
        modified:   types/abci.pb.go
        modified:   x/authz/tx.pb.go
        modified:   x/feegrant/tx.pb.go
        modified:   x/gov/types/genesis.pb.go
        modified:   x/gov/types/gov.pb.go
        modified:   x/gov/types/query.pb.go
        modified:   x/gov/types/query.pb.gw.go
        modified:   x/gov/types/tx.pb.go
        modified:   x/group/query.pb.go
        modified:   x/nft/event.pb.go
        modified:   x/nft/tx.pb.go
        modified:   x/upgrade/types/query.pb.go

[tac0turtle]

there have been some Proto merges without generation recently, this Is what is causing the issues. I hope to fix it Monday

[amaury1093]

lg, can we add a test?

[tac0turtle]

LGTM

[alexanderbez]

@AmauryM wanna give this another quick view?

[amaury1093]

LGTM, though I would like to confirm with CosmJS if we can backport this or not.

[amaury1093]

BTW: what's the long-term vision on Logs vs Events? Are we deprecating Logs, since it's redundant?

[alexanderbez]

Yah, I'd like to remove Logs, but the Logs contain message index and stuff like that. However, We can inject those into the Events. I'll open an issue for this.